[cherry-pick: release-v0.26.x] Remove symlinks - due to ko-build update#1746
Merged
Merged
Conversation
6 tasks
tekton-robot
added
the
size/XS
Contributor
|
/lgtm |
Member
|
/approve |
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #1738
Changes
Summary
kov0.19.1 introduced a security restriction that rejects symlinks in kodatathat resolve outside the kodata root directory. This broke all e2e tests in CI
since
setup-koinstalls the latest release.The
cmd/controller/kodata/directory contained symlinks to../../.git/HEADand
../../.git/refswhich are no longer used —knative.dev/pkg/changesetnow uses
debug.ReadBuildInfo()to get VCS info at runtime instead of readingfrom kodata.
Changes
cmd/controller/kodata/HEADsymlink (unused)cmd/controller/kodata/refssymlink (unused)cmd/controller/kodata/LICENSEsymlink with a real file copylogs from the failing tests:
2026-06-30T10:47:58.1714887Z Error: error processing import paths in "config/100-deployment.yaml": error resolving image references: tarring kodata: kodata symlink "/home/runner/work/chains/chains/cmd/controller/kodata/HEAD" resolves to "/home/runner/work/chains/chains/.git/HEAD" which is outside the kodata root "/home/runner/work/chains/chains/cmd/controller/kodata" 2026-06-30T10:47:58.1740223Z ERROR: Tekton Chains installation failed 2026-06-30T10:47:58.1742404Z *** E2E TEST FAILED ***Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes